Merge pull request #685 from Netflix/duration-gauge

add cycle start time and end time to comsumer metrics
Netflix · Jul 24, 2024 · 256f05d · 256f05d
2 parents 63d369b + 3f6629f
commit 256f05d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/hollow/src/main/java/com/netflix/hollow/api/client/HollowClientUpdater.java b/hollow/src/main/java/com/netflix/hollow/api/client/HollowClientUpdater.java
@@ -117,6 +117,7 @@ public synchronized boolean updateTo(long requestedVersion) throws Throwable {
         return updateTo(new HollowConsumer.VersionInfo(requestedVersion));
     }
     public synchronized boolean updateTo(HollowConsumer.VersionInfo requestedVersionInfo) throws Throwable {
+        metrics.setLastRefreshStartNs(System.nanoTime());
         long requestedVersion = requestedVersionInfo.getVersion();
         if (requestedVersion == getCurrentVersionId()) {
             if (requestedVersion == HollowConstants.VERSION_NONE && hollowDataHolderVolatile == null) {
@@ -205,6 +206,7 @@ public synchronized boolean updateTo(HollowConsumer.VersionInfo requestedVersion
                 metricsCollector.collect(metrics);
 
             initialLoad.complete(getCurrentVersionId()); // only set the first time
+            metrics.setLastRefreshEndNs(System.nanoTime());
             return getCurrentVersionId() == requestedVersion;
         } catch(Throwable th) {
             forceDoubleSnapshotNextUpdate();
@@ -216,6 +218,7 @@ public synchronized boolean updateTo(HollowConsumer.VersionInfo requestedVersion
 
             // intentionally omitting a call to initialLoad.completeExceptionally(th), for producers
             // that write often a consumer has a chance to try another snapshot that might succeed
+            metrics.setLastRefreshEndNs(System.nanoTime());
 
             throw th;
         }

diff --git a/hollow/src/main/java/com/netflix/hollow/api/metrics/HollowConsumerMetrics.java b/hollow/src/main/java/com/netflix/hollow/api/metrics/HollowConsumerMetrics.java
@@ -18,9 +18,31 @@
 
 import com.netflix.hollow.core.read.engine.HollowReadStateEngine;
 
+import java.util.concurrent.atomic.AtomicLong;
+
 public class HollowConsumerMetrics extends HollowMetrics {
     private int refreshFailed;      // TODO: Move these metrics over to com.netflix.hollow.api.consumer.metrics.AbstractRefreshMetricsListener
     private int refreshSucceeded;
+    private final AtomicLong lastRefreshStartNs = new AtomicLong(); //last time a refresh started
+    private final AtomicLong lastRefreshEndNs = new AtomicLong();
+
+    public void setLastRefreshStartNs(long startNs) {
+        lastRefreshStartNs.set(startNs);
+    }
+
+    public AtomicLong getLastRefreshStartNs() {
+        return lastRefreshStartNs;
+    }
+
+    public void setLastRefreshEndNs(long endNs) {
+        lastRefreshEndNs.set(endNs);
+    }
+
+    public AtomicLong getLastRefreshEndNs() {
+       return lastRefreshEndNs;
+    }
+
+
 
     /**
      * Updates the consumer metrics: