Fix: Escape control chars when stringifing JSON (#492) #672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was originally coded, this change assumes escaping is uncommon. The string is scanned first for characters that require escaping (i.e \ " and control characters). A single scan is performed checking for the presence of any of these three cases. The type of characters found are accumulated and used to only replace those that were found in the string.
The presence of a given category/type of escape character is done using bit-wise operations to avoid comparisons for performance (testing a character this way is 12% faster with jdk11 on an m1).