Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Working outside of application context" error, plus fix incorrect arg ordering for rotate by serial number #4969

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Fix "Working outside of application context" error, plus fix incorrect arg ordering for rotate by serial number #4969

merged 3 commits into from
Sep 30, 2024

Conversation

jtschladen
Copy link
Contributor

No description provided.

@jtschladen
Copy link
Contributor Author

Relates to #4764; this should correct the missing @with_appcontext issue, but not other issues reported there.

@charhate
Copy link
Contributor

I think there is one more file that use the fix - https://github.com/Netflix/lemur/blob/main/lemur/api_keys/cli.py

@jtschladen jtschladen merged commit 6dd0d4b into Netflix:main Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charhate charhate charhate approved these changes

@hosseinsh hosseinsh Awaiting requested review from hosseinsh hosseinsh is a code owner

@douglasc-nflx douglasc-nflx Awaiting requested review from douglasc-nflx douglasc-nflx is a code owner

@jmcrawford45 jmcrawford45 Awaiting requested review from jmcrawford45 jmcrawford45 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtschladen @charhate