Updated build.gradle to allow mantis-common-serde to be compiled using JDK 17 #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgrade JDK version to 17. This PR upgrades the
mantis-common-serde
module.Part of #355
spotlessJava
fails. This is becausegoogle-java-format
is broken on JDK 16+, and we use this package indirectly while formatting the code.google-java-format
uses are not exported by the JDK from JDK 16 onwards../gradlew build
. Therefore, to ensure the flags are added only when target is JDK 17,if(JavaVersion.current() != JavaVersion.VERSION_1_8)
has been created inside of which we add the required workaround flags.Screenshot of successful building of
mantis-common-serde
module using JDK 17Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests