Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withUrlParams to JobSource #758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crioux-stripe
Copy link
Collaborator

Context

We submit most of our jobs similar to Netflix with target parameter being submitted as part of the submission payload. However we also want to inject runtime details like which availability zone the worker is in that can only be known at runtime. This change would allow users to inject this sort of runtime info MantisJob.source(new JobSource().withUrlParams(myUrlParams)).stage(...) while still otherwise parsing the target param from Context.

cc @tcai-stripe

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link

Test Results

622 tests  ±0   612 ✅ ±0   8m 6s ⏱️ +5s
142 suites ±0    10 💤 ±0 
142 files   ±0     0 ❌ ±0 

Results for commit dad586e. ± Comparison against base commit 1ffc3b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant