[cards] performance optimizations #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
obgibson
reviewed
Feb 27, 2024
obgibson
requested changes
Feb 27, 2024
obgibson
approved these changes
Feb 28, 2024
valayDave
force-pushed
the
oss/cards-optimization
branch
from
0437318
to
fafeea5
Compare
- make refresh interval default smaller - remove timeout code block in card load - leveraging the `created_on` timestamps in dataupdates to discard stale data - handle case of idle refresh - comments on whats changed.
valayDave
force-pushed
the
oss/cards-optimization
branch
from
fafeea5
to
856ae53
Compare
valayDave
added a commit
to valayDave/metaflow-ui
that referenced
this pull request
Apr 15, 2024
- make refresh interval default smaller - remove timeout code block in card load - leveraging the `created_on` timestamps in dataupdates to discard stale data - handle case of idle refresh - comments on whats changed. - compatible with new changes introduced in Netflix/metaflow-service#417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created_ontimestamps in dataupdates to discard stale dataRequirements for a pull request
Changes compatible with : Netflix/metaflow-service#417