Metaflow Configs #1962
Merged
Metaflow Configs #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-intel
force-pushed
the
feat/configs
branch
3 times, most recently
from
b03a453 to
de97829
Compare
|
As a user interested in using a config file instead of using different sets of parameters, what would a config file look like? |
|
@bhogan-bdai -- the idea so far is to support a simple format like JSON (nested dicts basically) but other formats could be supported as well. We are also providing a |
romain-intel
force-pushed
the
feat/configs
branch
from
a4b601d to
bcdd987
Compare
saikonen
reviewed
Sep 12, 2024
romain-intel
force-pushed
the
feat/configs
branch
from
f172725 to
0f3d6d8
Compare
romain-intel
force-pushed
the
feat/configs
branch
2 times, most recently
from
5fdb25c to
bc57f77
Compare
romain-intel
force-pushed
the
feat/configs
branch
2 times, most recently
from
2bf8847 to
21f0c3a
Compare
npow
reviewed
Dec 5, 2024
| else: | ||
| kwargs["envvar"] = "METAFLOW_FLOW_%s" % option.upper() |
There was a problem hiding this comment.
This is click's way of indicating which env-var maps to that option. So yes, there is only one env-var that maps to the option.
romain-intel
force-pushed
the
feat/configs
branch
from
641def0 to
fc1a3b8
Compare
This was referenced Dec 6, 2024
Closed
This will allow parameters to be added when processing the `start` step (for the upcomming config change).
Previously, options like `branch` and `name` (injected by the project decorator for example) could be set using `METAFLOW_BRANCH`. They now need to be set using `METAFLOW_FLOW_BRANCH`. This change is made to prevent clashes between regular metaflow configuration settings and decorator level options. No other changes are made so `METAFLOW_RUN_MAX_WORKERS` still works as expected and `METAFLOW_PYLINT` as well.
Several fixes: - fixed an issue with default values - better handling of parameter defaults as configs - handle config defaults as functions - ConfigValue is more "dict"-like - made <myflow>.configs and <myflow>.steps work properly - renamed resolve_configs to init
Specifically: - moved things out of the INFO file - added to_dict - renamed user_configs to config_parameters
Specifically: - made config values immutable - cleaned up state stored in FlowSpec - added a test exercising configs in various places
- Separate out value and file (so default and default_value and --config and --config-value) - Provide classes for step and flow config decorators with proxy objects - Split things into several files (it was getting too long) - Addressed all bugs discussed
Fixed some typos and updated test to reflect latest code.
Fixed a few other issues:
- fixed an issue where a config was used in different decorators
causing it to produce an incorrect access string
- made the decorators work with or without arguments
…essages Use METAFLOW_DEBUG_USERCONF=1 to get a bit more detail. Should be feature complete now.
romain-intel
force-pushed
the
feat/configs
branch
from
12f28ec to
7a3a3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet fully ready but putting out so people can get a general sense of the direction.