Skip to content

Commit

Permalink
do not shade slf4j in spark jar (#1023)
Browse files Browse the repository at this point in the history
This makes it easier to have consistent logging and slf4j
typically isn't an issue with conflicting versions in the
spark distribution.
  • Loading branch information
brharrington authored Jan 6, 2023
1 parent 9fce0db commit b6576fd
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions spectator-ext-spark/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ shadowJar {
include project(':spectator-ext-jvm')
include project(':spectator-reg-sidecar')
include dependency('com.typesafe:config')
include dependency('org.slf4j:slf4j-api')
}
minimize()

Expand All @@ -53,7 +52,6 @@ shadowJar {
relocate 'com.netflix.spectator.ipc', 'spectator-ext-spark.ipc'
relocate 'com.netflix.spectator.jvm', 'spectator-ext-spark.jvm'
relocate 'com.netflix.spectator.sidecar', 'spectator-ext-spark.sidecar'
relocate 'org.slf4j', 'spectator-ext-spark.slf4j'
relocate 'com.typesafe', 'spectator-ext-spark.com.typesafe'
}

0 comments on commit b6576fd

Please sign in to comment.