Simplify ArrayTagSet sort method #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of unnecessary branches in ArrayTagSet's insertionSort method.
|
IIRC the branch was to avoid the loops in the simple case. We would need to do some testing to verify the performance with this change is better or neutral. |
brharrington
added a commit
to brharrington/spectator
that referenced
this pull request
Oct 25, 2023
Verify performance behavior of Netflix#1079. Case with two tags is quite a bit slower with the simplification.
|
In my testing it makes a common case of two tags about 20% slower (#1088). |
brharrington
added a commit
that referenced
this pull request
Oct 25, 2023
Verify performance behavior of #1079. Case with two tags is quite a bit slower with the simplification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of unnecessary branches in ArrayTagSet's insertionSort method.