Add empty fn for doing things with the client and origin channels #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderEllis
requested review from
sullis,
jguerra,
argha-c,
connorworley,
karim-z,
kyagna and
lindseyreynolds
kyagna
approved these changes
Nov 17, 2023
|
Can you explain the issue this solves more? |
|
@argha-c the general idea is to enable some gentle experimentation with some sort of synchronization between the origin and client channel for servers with unique request patterns. Namely, cases where the origin channel and the client channel being out of band leads to issues. Just to emphasize again, this is not intended to be a large-scale change to zuul's behavior. This is just adding a hook to let us play with this idea more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a nice empty function for now to allow for overriding and experimentation.