Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remaining FPs in ConnectionPoolConfigImpl with niws style #1784

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Replace remaining FPs in ConnectionPoolConfigImpl with niws style #1784

merged 3 commits into from
Jun 20, 2024

Conversation

jguerra
Copy link
Contributor

@jguerra jguerra commented Jun 20, 2024

No description provided.

@jguerra jguerra merged commit 83ce0a3 into master Jun 20, 2024
5 checks passed
argha-c pushed a commit that referenced this pull request Sep 10, 2024
@jguerra @argha-c
Replace remaining FPs in ConnectionPoolConfigImpl with niws style (#1784
e8a30c9 
)

* Switch ConnectionPoolConfigImpl to only use niws configuration

* Add unit tests

* Import order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argha-c argha-c argha-c approved these changes

@gavinbunney gavinbunney Awaiting requested review from gavinbunney

@lindseyreynolds lindseyreynolds Awaiting requested review from lindseyreynolds

@AlexanderEllis AlexanderEllis Awaiting requested review from AlexanderEllis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jguerra @argha-c