Make sure promise finishes during graceful shutdowns #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome channels fail to close
argha-c
reviewed
Aug 19, 2024
| @@ -113,7 +113,14 @@ Promise<Void> gracefullyShutdownClientChannels(boolean forceCloseAfterTimeout) { | |||
| ScheduledFuture<?> timeoutTask = executor.schedule( | |||
| () -> { | |||
| LOG.warn("Force closing remaining {} active client channels.", channels.size()); | |||
| channels.close(); | |||
| channels.close().addListener(future -> { | |||
There was a problem hiding this comment.
This shouldn't be necessary.
The graceful close promise will not finish if some channels error out while closing.
This sounds incorrect. The closeFuture should be invoked even if certain channels error out on close(). It has the listener wired to set a success on the Promise. Where do you see this not being set?
There was a problem hiding this comment.
It was behavior I suspected while validating our signal handling, but then also verified with a unit test. If one of the handlers in the group throws during close() handling then the closeFuture is not completed, and the channel remains in the group
There was a problem hiding this comment.
That's really odd. Anyway, this doesn't hurt 🚢
argha-c
approved these changes
Aug 20, 2024
argha-c
pushed a commit
that referenced
this pull request
Sep 10, 2024
* During graceful shutdowns make sure to still finish promise even if some channels fail to close * Fix import order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graceful close promise will not finish if some channels error out while closing. Make sure to finish the promise even if some channels have errors during closing