Add new retry policy adjustment method #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argha-c
reviewed
Sep 17, 2024
| @@ -77,4 +80,8 @@ RequestAttempt newRequestAttempt( | |||
| IClientConfig getClientConfig(); | |||
|
|
|||
| Registry getSpectatorRegistry(); | |||
|
|
|||
| default void adjustRetryPolicyIfNeeded(HttpRequestMessage zuulRequest, @Nullable HttpResponse response) { | |||
| adjustRetryPolicyIfNeeded(zuulRequest); | |||
There was a problem hiding this comment.
Can we avoid this overload by using an || on the original method and a new one derived from the response?
That feels cleaner imo.
There was a problem hiding this comment.
I added a new (awkwardly named) method originRetryPolicyAdjustmentIfNeeded
There was a problem hiding this comment.
Naming is hard. It just needs to convey that the adjustment is inferred by the origin response.
argha-c
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a more specific adjustRetryPolicyIfNeeded for cases when we have a HttpResponse from the origin (e.g. origin returned 503)