Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mwan): refactored mwan #43

Merged
merged 14 commits into from
Oct 3, 2023
Merged

refactor(mwan): refactored mwan #43

merged 14 commits into from
Oct 3, 2023

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Sep 25, 2023

Refactored whole MWAN due to API changes

  • Refactored every component as action (PolicyCreator, PolicyEditor, RuleDeleter, ecc...)
  • Sharing common code between Creator views and Editor views
  • Added validation for port range and port
  • Removed unused views/composables

To merge after: NethServer/nethsecurity#172

@Tbaile Tbaile marked this pull request as ready for review September 29, 2023 13:42
@Tbaile Tbaile requested a review from andre8244 September 29, 2023 13:43
public/i18n/en/translation.json Outdated Show resolved Hide resolved
public/i18n/en/translation.json Outdated Show resolved Hide resolved
src/composables/usePolicyForm.ts Outdated Show resolved Hide resolved
@Tbaile Tbaile requested a review from andre8244 October 3, 2023 13:37
@Tbaile Tbaile changed the title refactor(mwan): refactoring due to api changes refactor(mwan): refactored mwan Oct 3, 2023
@Tbaile Tbaile merged commit ed51ca8 into main Oct 3, 2023
@Tbaile Tbaile deleted the mwan-refactor branch October 3, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants