fix(port forward): adding tooltip for disabled port forwards #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
sdl-898
branch
2 times, most recently
from
a2df8d7 to
b4286f9
Compare
gsanchietti
reviewed
Jan 13, 2025
gsanchietti
previously approved these changes
Jan 13, 2025
andre8244
previously approved these changes
Jan 13, 2025
Co-authored-by: Giacomo Sanchietti <[email protected]>
gsanchietti
approved these changes
Jan 13, 2025
andre8244
approved these changes
Jan 13, 2025
Tbaile
changed the title
gsanchietti
added a commit
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a tooltip for inactive port forwards when the header contains a hyphen and add translations for the inactive status and range object compatibility.
NethServer/nethsecurity#898
if I revert the host range
Note:
it seems we need to save the upper unsaved change button if we want the change is effective