fix: few fixes when config changes

packages/ns-api/files/ns.snort

@@ -202,6 +202,6 @@ else:
                 raise ValidationError('oinkcode', 'invalid')
             print(json.dumps({"status": "success"}))
         else:
-            utils.validation_error('action', 'invalid')
+            print(json.dumps(utils.generic_error(f"Unknown action: {action}")))
     except ValidationError as e:
         print(json.dumps(utils.validation_error(e.parameter, e.message, e.value)))

packages/snort3/files/snort.init

@@ -32,19 +32,17 @@ update_bypass_set() {
     fi
 }
 
-download_rules_if_needed () {
-	if ! find /var/ns-snort/rules/ -type f -name "*.rules" | grep -q . ; then
-		# no rules file found, start downloaded loop
-		attempt=0
-		until /usr/bin/ns-snort-rules --download; do
-			attempt=$((attempt + 1))
-			if [ "$attempt" -ge 6 ]; then
-				echo "Error: failed to download snort rules after 6 attempts (1 minute)."
-				break
-			fi
-			sleep 10
-		done
-	fi
+download_rules () {
+  # this is done every time the service is started
+  attempt=0
+  until /usr/bin/ns-snort-rules --download; do
+    attempt=$((attempt + 1))
+    if [ "$attempt" -ge 6 ]; then
+      echo "Error: failed to download snort rules after 6 attempts (1 minute)."
+      break
+    fi
+    sleep 10
+  done
 }
 
 setup_tweaks() {
@@ -82,7 +80,7 @@ start_service() {
 		update_bypass_set "bypass_dst_v4"
 		update_bypass_set "bypass_src_v6"
 		update_bypass_set "bypass_dst_v6"
-		download_rules_if_needed
+		download_rules
 		setup_tweaks
 	fi
 
@@ -123,3 +121,9 @@ service_triggers()
 	procd_add_reload_trigger "snort"
 	procd_add_validation validate_snort_section
 }
+
+reload_service()
+{
+  stop
+  start
+}