fix: review changes

NethServer · Sep 29, 2023 · eca1852 · eca1852
1 parent 05dc688
commit eca1852
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/ns-api/Makefile b/packages/ns-api/Makefile
@@ -89,6 +89,8 @@ define Package/ns-api/install
 	$(INSTALL_DATA) ./files/ns.dhcp.json $(1)/usr/share/rpcd/acl.d/
 	$(INSTALL_BIN) ./files/ns.dns $(1)/usr/libexec/rpcd/
 	$(INSTALL_DATA) ./files/ns.dns.json $(1)/usr/share/rpcd/acl.d/
+	$(INSTALL_BIN) ./files/ns.mwan $(1)/usr/libexec/rpcd/
+    $(INSTALL_DATA) ./files/ns.mwan.json $(1)/usr/share/rpcd/acl.d/
 	$(INSTALL_DIR) $(1)/lib/upgrade/keep.d
 	$(INSTALL_CONF) files/msmtp.keep $(1)/lib/upgrade/keep.d/msmtp
 	$(LN) /usr/bin/msmtp $(1)/usr/sbin/sendmail

diff --git a/packages/ns-api/files/ns.mwan b/packages/ns-api/files/ns.mwan
@@ -102,11 +102,11 @@ elif cmd == 'call':
                 data['name'],
                 data['policy'],
                 data['label'],
-                data['protocol'] if 'protocol' in data else None,
-                data['source_address'] if 'source_address' in data else None,
-                data['source_port'] if 'source_port' in data else None,
-                data['destination_address'] if 'destination_address' in data else None,
-                data['destination_port'] if 'destination_port' in data else None,
+                data['protocol'],
+                data['source_address'],
+                data['source_port'],
+                data['destination_address'],
+                data['destination_port'],
             )
             print(json.dumps({'message': 'success'}))
     except KeyError as e: