ns-phonehome: removing version from facts #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaile
changed the title
Signed-off-by: Tommaso Bailetti <[email protected]>
Tbaile
force-pushed
the
fix-phonehome-version-parsing
branch
from
0d3af33 to
13d5852
Compare
|
Server fix ref: |
|
Deployment done, PR ready |
gsanchietti
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened now the latest version, it appears that the version is uncorrectly stripped out of endline and quotes (from /etc/os-release)This fix works with both latest versions and testing onesRemoved version definition in facts, for Nethsecurity expecting to use version inside distro object.