refactor(ns-api): refactored dpi report stats reporting #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaile
force-pushed
the
issue-937
branch
2 times, most recently
from
fb1e797 to
0d419d4
Compare
gsanchietti
reviewed
Nov 29, 2024
Tbaile
force-pushed
the
issue-937
branch
4 times, most recently
from
91d35d7 to
bc61a2f
Compare
gsanchietti
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes needed for filtering in #937 the code was refactored to offer the functionality needed for the UI feature implementation.
To avoid issues, merge only after implementation coming from #900.This can, in fact, be safely added as an additional feature while deprecating the other API to avoid breaking changes.
The old
summaryhas been backported, this can be safely merged.