Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ns-api): gracefully handle error when checking for updates #990

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

Tbaile
Copy link
Contributor

@Tbaile Tbaile commented Dec 23, 2024

If for any reason the upstream update server goes offline (both community and enterprise repositories), several issues arise while viewing the Updates page.
By adding the python3-requests package it's possible to figure what is going wrong and what happened to the request, leaving the UI with specific error messages that allows to tell the user exactly what is going on.

@Tbaile Tbaile added this to the NethSecurity 8.5 milestone Dec 23, 2024
@Tbaile Tbaile requested a review from gsanchietti December 23, 2024 15:34
@Tbaile Tbaile marked this pull request as ready for review December 23, 2024 15:34
@Tbaile Tbaile changed the title fix: gracefully handle error in update page fix(ns-api): gracefully handle error when checking for updates Dec 23, 2024
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handlers for python-requests call are ok, but restore missing handler for uci.get

packages/ns-api/files/ns.update Outdated Show resolved Hide resolved
@Tbaile Tbaile requested a review from gsanchietti January 7, 2025 08:19
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an issue for it before merging

@Tbaile Tbaile merged commit 9af18e9 into main Jan 7, 2025
1 check passed
@Tbaile Tbaile deleted the update-error-handling branch January 7, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

2 participants