Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LDAP user domain in connection configuration #96

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Dec 5, 2024

Enhance the connection configuration by incorporating the LDAP user domain and improving the UI for better readability.

NethServer/dev#7103

image

@nethbot
Copy link
Member

nethbot commented Dec 5, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.12.pr96.g0d3625a.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Dec 5, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.13.pr96.gb3cd735.ns7.x86_64.rpm x86_64

Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ldap. prefix is not needed. Any domain name is acceptable, the only condition is that it is unique in the NS8 cluster and has at least one dot inside.

api/connection/read Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
@gsanchietti
Copy link
Member

The ldap. prefix is not needed. Any domain name is acceptable, the only condition is that it is unique in the NS8 cluster and has at least one dot inside.

While this is true, it's not the way NS8 configures the domain: it adds something leader, or ad before the domain when configuring one.
Since many users are still using bad FQDN for their machines, IMO having the ldap prefix could possible prevent some naming conflicts.

@stephdl
Copy link
Contributor Author

stephdl commented Dec 5, 2024

in NS8, the behavior for an openldap account provider is to get the domain of the server, do not know :p

Capture.video.du.2024-12-05.15-59-33.mp4

@DavidePrincipi
Copy link
Member

It is the same behavior of NS7.

AD prepends ad. as Microsoft recommends, it is documented in our manual. https://docs.nethserver.org/projects/ns8/en/latest/user_domains.html#dns-and-ad-domain

@stephdl
Copy link
Contributor Author

stephdl commented Dec 5, 2024

I tested the short domain domain.com, workable, let's go to it, we could still go back if we see issue

@nethbot
Copy link
Member

nethbot commented Dec 5, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.14.pr96.g489ceab.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Dec 5, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.15.pr96.ga1e5fe3.ns7.x86_64.rpm x86_64

@stephdl stephdl merged commit 0fb792d into master Dec 6, 2024
1 check passed
@stephdl stephdl deleted the sdl-7103-placeholder branch December 6, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants