Fix UI of dokuwiki (hostname and first configuration only) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
changed the title
stephdl
changed the title
andre8244
requested changes
Mar 14, 2024
There was a problem hiding this comment.
- "This instance cannot be configured anymore here" -> Not true, FQDN can still be configured here. I suggest: title="Note", description="You can configure only Dokuwiki FQDN in this page. To configure other setting go to [link]" (do we know the specific link?)
|
hum yes we could display a link, it is the FQDN of the dokuwiki instance |
andre8244
reviewed
Mar 14, 2024
Co-authored-by: Andrea Leardini <[email protected]>
andre8244
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix the hostname, we must require a true FQDN (mainly for lets encrypt)
https://community.nethserver.org/t/ns8-dokuwiki-wiki-fqdn-validation/23114
This PR fix the first configuration only issue of dokuwiki, the container reads the env variables just once at the first boot of the container and write the configuration files, even if you modify the environment variables,they are not not used
The fix is to display a banner to inform what to do and disable all the fields
https://community.nethserver.org/t/ns8-dokuwiki-instance-settings-applied-only-the-first-time/23104
refs: NethServer/dev#6894