Add file age check and maxage parameter for synchronization #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FIRSTRUN="false" | ||
| fi | ||
| # retrieve unixtimestamp | ||
| date +"%Y-%m-%d %H:%M:%S" > /etc/imapsync/${task_id}.timestamp |
There was a problem hiding this comment.
At this point it is better to store the timestamp value in a script variable, then write the timestamp only after a successful imapsync run. If flock or imapsync fail, the timestamp should not be written.
Suggested change
| date +"%Y-%m-%d %H:%M:%S" > /etc/imapsync/${task_id}.timestamp | |
| timestamp="$(date +%s)" |
Furthermore, writing a timestamp string in the file is not necessary because the stat command reads the file metadata.
Suggested change
| date +"%Y-%m-%d %H:%M:%S" > /etc/imapsync/${task_id}.timestamp | |
| touch -m -d "@${timestamp}" /etc/imapsync/${task_id}.timestamp |
| get_file_age_in_days() { | ||
| local filename="$1" | ||
| # Get last access time in Unix timestamp | ||
| local last_access=$(stat -c %X "$filename") |
There was a problem hiding this comment.
%Y is for data modification time. %X, access time is not reliable.
Suggested change
| local last_access=$(stat -c %X "$filename") | |
| local last_access=$(stat -c %Y "$filename") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a file age check and a maxage parameter to optimize synchronization by determining the age of the timestamp file. This enhancement allows for more efficient handling of synchronization tasks.
Refs NethServer/dev#7296