Fix the collabora in nextcloud #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
fixCollabora
branch
from
7080fdf to
7eef9c7
Compare
DavidePrincipi
requested review from
gsanchietti
and removed request for
DavidePrincipi
gsanchietti
approved these changes
Nov 14, 2023
|
@gsanchietti I hope I answered |
|
Go on with the merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test of nextcloud 27.1.3 ok
test of collabora ok with the fix of this PR
smarthost are set in nextcloud
tested collabora with version 21.11.5.3 and 23.05.5.4.1 (new version from NethServer/ns8-collabora#12)
first install or upgrade from 21.11.5.3 is good
the fix is needed to get a default value for
tls_verify_collaborabecause nextcloud is a special beast reading from a json file its configuration and like https://github.com/NethServer/ns8-nextcloud/blob/fixCollabora/imageroot/actions/get-configuration/20read#L38 for lets_encrypt if the file config.json file does not exist we except to a default value forlets_encrypt, then at the first save of the configuration we write it. Else except the first time you save true totls_verify_collabora, this property is not know by the UI because never initiated.