Try to explain better user ldap domain and collabora code widget #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
changed the title
There was a problem hiding this comment.
Ok, but the Host name placeholder must adhere to this list of guidelines NethServer/dev#6806 (comment)
ui/public/i18n/en/translation.json
Outdated
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "common": { | |||
| "required": "Required", | |||
| "work_in_progress": "Work in progress" | |||
| "work_in_progress": "Work in progress", | |||
| "eg_value": "E.g. {value}" | |||
There was a problem hiding this comment.
I'd prefer using a static label, with a example.com domain suffix that strengthen furthermore the fact that it is just an example...
Suggested change
| "eg_value": "E.g. {value}" | |
| "eg_value": "e.g. mynextcloud.example.com" |
The purpose of the placeholder is not suggesting a suitable value, but clarify what kind of value the input field expects. In this case it is a FQDN host name.
There was a problem hiding this comment.
I did it a bit differently, we cannot send to translation a hostname, it could be changed by the translators
DavidePrincipi
requested changes
Dec 20, 2023
DavidePrincipi
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update translation.json with LDAP-related changes
This pull request includes a refactoring of the Settings.vue component and updates the translation.json file with LDAP-related changes.
NethServer/dev#6806