Fix LDAP dn splitting issue in get-password-policy handlers

NethServer · Apr 30, 2024 · 46bf007 · 46bf007
1 parent 32f52a4
commit 46bf007
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/imageroot/actions/get-password-policy/50get_password_policy b/imageroot/actions/get-password-policy/50get_password_policy
@@ -31,8 +31,9 @@ ppolicy = {
         "complexity_check": False,
     }
 }
-
-for line in ldapsearch_proc.stdout.split("\n"):
+# In case of long LDAP dn we could have a \n inside the dn, so we can't split 
+# split only if we got a line that ends with a \n$, which is the separator
+for line in ldapsearch_proc.stdout.split("\n$"):
     if not line:
         continue
 

diff --git a/imageroot/api-moduled/handlers/get-configuration/post b/imageroot/api-moduled/handlers/get-configuration/post
@@ -31,8 +31,9 @@ ppolicy = {
         "complexity_check": False,
     }
 }
-
-for line in ldapsearch_proc.stdout.split("\n"):
+# In case of long LDAP dn we could have a \n inside the dn, so we can't split 
+# split only if we got a line that ends with a \n$, which is the separator
+for line in ldapsearch_proc.stdout.split("\n$"):
     if not line:
         continue
 

diff --git a/imageroot/api-moduled/handlers/get-password-policy/post b/imageroot/api-moduled/handlers/get-password-policy/post
@@ -31,8 +31,9 @@ ppolicy = {
         "complexity_check": False,
     }
 }
-
-for line in ldapsearch_proc.stdout.split("\n"):
+# In case of long LDAP dn we could have a \n inside the dn, so we can't split 
+# split only if we got a line that ends with a \n$, which is the separator
+for line in ldapsearch_proc.stdout.split("\n$"):
     if not line:
         continue