Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User management portal API #15

Merged
merged 3 commits into from
Oct 17, 2023
Merged

User management portal API #15

merged 3 commits into from
Oct 17, 2023

Conversation

DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Oct 16, 2023 •
edited
Loading

  • Configure and start api-moduled instance to serve backend API
  • Configure Traefik path-based route for the web portal
  • Implement basic API: login and change-password handlers

Requires

@DavidePrincipi
User management portal
ae549f5 
- Configure and start api-moduled instance to serve backend API
- Configure Traefik path-based route for the web portal
- Implement basic API: login and change-password handlers
@DavidePrincipi DavidePrincipi self-assigned this Oct 16, 2023
@DavidePrincipi DavidePrincipi marked this pull request as ready for review October 16, 2023 14:27
gsanchietti
gsanchietti requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the path of the user interface should be customizable: if you have multiple openldap instances, they will conflict on the same URL.

@DavidePrincipi
Copy link
Member Author

DavidePrincipi commented Oct 16, 2023 •
edited
Loading

Also the path of the user interface should be customizable: if you have multiple openldap instances, they will conflict on the same URL.

Multiple LDAP instances on the same node for the same domain is possible, but doesn't make any sense. In the end one of them will take the route: I don't see the point.

@DavidePrincipi DavidePrincipi removed the request for review from andre8244 October 16, 2023 15:22
@DavidePrincipi
Advertise "users-admin" service
7d0d52e 
The users management portal can be discovered like other services and
if its settings are added, or changed the `service-users-admin-changed`
event is raised.
gsanchietti
gsanchietti approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced: there is no way way for a user to know where the route is bound.
Let's hope we can expose this info somehow on the UI

@DavidePrincipi DavidePrincipi merged commit c5726f5 into main Oct 17, 2023
1 check passed
@DavidePrincipi DavidePrincipi deleted the user-portal branch October 17, 2023 10:58
@DavidePrincipi DavidePrincipi mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsanchietti gsanchietti gsanchietti approved these changes

@edospadoni edospadoni edospadoni approved these changes

Assignees

@DavidePrincipi DavidePrincipi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidePrincipi @gsanchietti @edospadoni