Fix restore of RETENTION_DAYS variable #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes modify the handling of the `RETENTION_DAYS` environment variable in the `clone-module` and `restore-module` actions. The variable is now converted to an integer before being used. This update improves the consistency and reliability of the code.
DavidePrincipi
approved these changes
May 30, 2024
…ept only for restoration/clone action The code changes remove unnecessary code related to altering relay rules and setting always-bcc address for the mail server in the `configure-module` script. This simplifies the script and improves its efficiency.
|
@DavidePrincipi some little changes
clone action and restoration are good |
DavidePrincipi
approved these changes
May 31, 2024
DavidePrincipi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes modify the handling of the
RETENTION_DAYSenvironment variable in theclone-moduleandrestore-moduleactions. The variable is now converted to an integer before being used.The unused json property
restorehas been removedas a side note backup/restore and clone must be tested again
Refs NethServer/dev#6895