Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition to check for 'addusers' key in get-configuration script #30

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Fix condition to check for 'addusers' key in get-configuration script #30

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
26735ec
Fix condition to check for 'addusers' key in get-configuration script
stephdl Feb 5, 2024
df0e7a4
Merge branch 'main' of github.com:NethServer/ns8-roundcubemail into d…
stephdl Feb 5, 2024
84d03de
Fix condition to check if 'addusers' is True in get-configuration
stephdl Feb 6, 2024
520f54e
Add error message for no available mail domain
stephdl Feb 6, 2024
0b171de
Add default value for empty mail server URL
stephdl Feb 6, 2024
c08b8e4
Refactor condition to simplify code
stephdl Feb 6, 2024
b6b4b7b
Add warning notification for misconfigured mail module
stephdl Feb 6, 2024
a73b526
Add error message for misconfigured mail module
stephdl Feb 6, 2024
ac2e161
Update mail domain error messages
stephdl Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion imageroot/actions/get-configuration/20read
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ for key in agent.list_service_providers(rdb,'imap','tcp'):
mail = key['module_id']
get_retval = agent.tasks.run(f"module/{mail}",'list-domains')
for kd in get_retval['output']:
if kd['addusers']:
if 'addusers' in kd:
obj = {
"name": key['module_id'],
"label": f"{kd['domain']} ({key['mail_hostname']})",
Expand Down
Loading