Add LDAP addressbook #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
ldapAddressBook
branch
from
cec2ad6 to
0043bed
Compare
stephdl
commented
Apr 29, 2024
There was a problem hiding this comment.
When a module becomes an accountconsumer, it must create the LDAP domain reference, and keep it updated
https://nethserver.github.io/ns8-core/core/user_domains/#bind-modules-and-account-domains
The configure-module action should do it, because it has a Redis connection with the leader node. On the contrary, discover-service has a replica connection and does not suite for this purpose.
stephdl
force-pushed
the
ldapAddressBook
branch
from
a270da5 to
9be1b66
Compare
stephdl
force-pushed
the
ldapAddressBook
branch
from
9be1b66 to
ac2b49f
Compare
DavidePrincipi
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the build-images.sh script, discover-service script, and roundcubemail.service file. The changes include adding a cluster:accountconsumer authorization label to build-images.sh, updating LDAP configuration in the discover-service script, and adding network and host configurations to roundcubemail.service.
refs: NethServer/dev#6914