Fix Custom Certificate Handling and Storage in Redis #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that certificates are stored in Redis using base64 encoding.
Ensure certificates are stored in base64 format within the Redis DB.
Tbaile
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues related to the handling and storage of custom certificates, ensuring proper functionality and format consistency.
Key Changes:
Fix event payload in upload-certificate
Adjusted the event payload structure to ensure correct handling of certificate uploads.
Fix certificate format in Redis
Ensured certificates are stored in base64 format within Redis for consistency and correct retrieval.
Tests for custom certificate storage
Added tests to verify that custom certificates are properly stored in Redis using base64 encoding.
NethServer/dev#6986