Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass custom args to Podman #74

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat: pass custom args to Podman #74

merged 1 commit into from
Feb 10, 2025

Conversation

DavidePrincipi
Copy link
Member

The PODMAN_RUN_OPTS environment variable can be set to custom values. For example it can be used to set an additional environment variable for Traefik runtime, like LEGO_CA_CERTIFICATES.

Refs NethServer/dev#7300

Copy link
Contributor

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If variable envs are the need to properly configure traefik, why not an external .env that can be safely backupped and persistent? This separates module logic and environment from application specific behaviour

@DavidePrincipi
Copy link
Member Author

I started with a Podman env file, but --env-file requires that the file exists. With a generic placeholder like $PODMAN_RUN_OPTS we have a generic customization point, where any option can be added, --env-file included.

About backup/restore support for customization, I will think about it after making it working for the app data.

@DavidePrincipi DavidePrincipi changed the base branch from feat-7158-1 to feat-7158 February 10, 2025 11:41
The PODMAN_RUN_OPTS environment variable can be set to custom values.
For example it can be used to set an additional environment variable for
Traefik runtime, like LEGO_CA_CERTIFICATES.
@DavidePrincipi DavidePrincipi merged commit 68f6bf2 into feat-7158 Feb 10, 2025
1 of 4 checks passed
@DavidePrincipi DavidePrincipi deleted the feat-7158-3 branch February 10, 2025 11:51
DavidePrincipi added a commit that referenced this pull request Feb 10, 2025
The PODMAN_RUN_OPTS environment variable can be set to custom values.
For example it can be used to set an additional environment variable for
Traefik runtime, like LEGO_CA_CERTIFICATES.

Refs NethServer/dev#7300
DavidePrincipi added a commit that referenced this pull request Feb 17, 2025
The PODMAN_RUN_OPTS environment variable can be set to custom values.
For example it can be used to set an additional environment variable for
Traefik runtime, like LEGO_CA_CERTIFICATES.

Refs NethServer/dev#7300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants