Skip to content

Commit

Permalink
Fix missing settings on migration
Browse files Browse the repository at this point in the history
Some defaults of the WebTop application are stored in the PostgreSQL
database. To create new defaults or modify existing ones, the settings
are changed in the initialization script during a fresh installation or
via the `update-module.d` step during an update.

However, during migration, the step in `update-module.d` is not
executed, and the database initialization script is not invoked because
the database is restored from a dump of the old one. As a result, the
new default settings are not adjusted.

Since the `configure-module` action is launched as the final step of
migration, as a workaround, the setting adjustment step from
`update-module.d` is also included in `configure-module`.
  • Loading branch information
Amygos committed Sep 27, 2024
1 parent 26652cf commit 75a7793
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions imageroot/actions/configure-module/21update_settings
3 changes: 3 additions & 0 deletions imageroot/update-module.d/11update_settings
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
# SPDX-License-Identifier: GPL-3.0-or-later
#

# WARNING: This step is executed also in the `configure-module` action on step
# `21upate_settings, be aware of that.

import sys
import agent
import subprocess
Expand Down

0 comments on commit 75a7793

Please sign in to comment.