Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend webtop.properties with custom contents #60

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Jul 31, 2024

Change expandconfig-webapp to generate contents from the templates/webtop.properties.d/ directory.

User can override the builtin directory by creating state/webtop.properties.d/, with the same beloved semantics of template-custom in NS7.

The optional custom directory is added to the backup set.

  • Update README

This feature is required for the next Webtop release, containing Pecbridge NethServer/dev#6984

@DavidePrincipi DavidePrincipi self-assigned this Jul 31, 2024
@DavidePrincipi DavidePrincipi marked this pull request as ready for review September 18, 2024 16:09
Change expandconfig-webapp to generate contents from the
templates/webtop.properties.d/ directory.

User can override the builtin directory by creating
state/webtop.properties.d/, with the same beloved semantics of
template-custom in NS7.

The optional custom directory is added to the backup set.
Without `set -a`, the subsequent `envsubst` cannot access the
imported variables.
@Amygos Amygos merged commit d7f5bd4 into main Sep 23, 2024
4 checks passed
@Amygos Amygos deleted the feat-customcfg branch September 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants