Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra } generated when ret ++ fargs is empty #3

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Coda-Coda
Copy link
Collaborator

Add missing $ so that the use of generateGuarded behaves correctly.

This fixes, for example, in the erc20 branch currently in Generated/erc20shim/ERC20Shim/panic_error_0x11_user.lean we have: lemma panic_error_0x11_abs_of_concrete {s₀ s₉ : State} } : on line 15.

For other occurrences of this bug, grep -r "} }" in the erc20 branch - currently (e4c216).

@Coda-Coda
Copy link
Collaborator Author

To see the effect, it may be necessary to first delete the relevant files in the Generated/erc20shim directory as it seems that the vc tool doesn't overwrite existing files.

Copy link
Collaborator

@jkopanski jkopanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm going to merge this one as it targets main as opposed to #4

@jkopanski jkopanski merged commit a8862bf into NethermindEth:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants