Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in RLP and Withdrawals #57

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andreiburdusa
Copy link
Contributor

@andreiburdusa andreiburdusa commented Oct 31, 2024

After #56

  • compare the sender address recovered to the sender address given in the tests
  • fix mistake in RLP encoding of legacy transactions
  • make withdrawals optional, not all blocks have withdrawals

Results:
Overall, not checking the balance and not having reconciled the expected errors yet, there are approximatively

  • 425 tests blacklisted
  • 22,265 tests running
  • 18,092 tests succeeding

18,092 / (22,265 + 425) = 79.7%

@andreiburdusa andreiburdusa marked this pull request as ready for review November 1, 2024 05:38
@andreiburdusa andreiburdusa mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant