Minor _Scarb.toml_ refactors (#251)

* Set one common edition version in workspace Scarb.toml * move snforge_std to dev-deps * Remove [lib] from coin_flip and simple_storage_starknetjs * rebuild projects * remove casm attr from scarb.toml * Update foundry to 0.31.0 in tool-versions * Set workspace cairo_test in mappings * Add missing cairo_test.workspace attrbs to Scarb.tomls * Revert snforge_std to 0.30.0 * Revert "Add missing cairo_test.workspace attrbs to Scarb.tomls" This reverts commit 7a9131d.
NethermindEth · Oct 24, 2024 · 024cd07 · 024cd07
1 parent 7e8358e
commit 024cd07
Show file tree

Hide file tree

Showing 41 changed files with 47 additions and 52 deletions.
diff --git a/.tool-versions b/.tool-versions
@@ -1,2 +1,2 @@
 scarb 2.8.2
-starknet-foundry 0.30.0
+starknet-foundry 0.30.0
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -112,7 +112,6 @@ version.workspace = true
 
 [dependencies]
 starknet.workspace = true
-snforge_std.workspace = true
 # Uncomment the following lines if you want to use additional dependencies:
 # OpenZeppelin:
 # openzeppelin.workspace = true
@@ -122,6 +121,7 @@ snforge_std.workspace = true
 
 [dev-dependencies]
 assert_macros.workspace = true
+snforge_std.workspace = true
 
 [scripts]
 test.workspace = true

diff --git a/Scarb.toml b/Scarb.toml
@@ -27,6 +27,7 @@ homepage = "https://www.nethermind.io/"
 license = "MIT"
 authors = ["julio4", "msaug"]
 version = "0.1.0"
+edition = "2024_07"
 
 [tool]
 snforge.workspace = true
diff --git a/listings/advanced-concepts/ecdsa_verification/Scarb.toml b/listings/advanced-concepts/ecdsa_verification/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "ecdsa_verification"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/hash_solidity_compatible/Scarb.toml b/listings/advanced-concepts/hash_solidity_compatible/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "hash_solidity_compatible"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/hash_trait/Scarb.toml b/listings/advanced-concepts/hash_trait/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "hash_trait"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/library_calls/Scarb.toml b/listings/advanced-concepts/library_calls/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "library_calls"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/simple_account/Scarb.toml b/listings/advanced-concepts/simple_account/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "simple_account"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/store_using_packing/Scarb.toml b/listings/advanced-concepts/store_using_packing/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "store_using_packing"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/struct_as_mapping_key/Scarb.toml b/listings/advanced-concepts/struct_as_mapping_key/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "struct_as_mapping_key"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/advanced-concepts/write_to_any_slot/Scarb.toml b/listings/advanced-concepts/write_to_any_slot/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "write_to_any_slot"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/advanced_factory/Scarb.toml b/listings/applications/advanced_factory/Scarb.toml
@@ -1,20 +1,19 @@
 [package]
 name = "advanced_factory"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true
 components.workspace = true
-snforge_std.workspace = true
 crowdfunding = { path = "../crowdfunding" }
 
 [dev-dependencies]
 assert_macros.workspace = true
+snforge_std.workspace = true
 
 [scripts]
 test.workspace = true
 
 [[target.starknet-contract]]
-casm = true
 build-external-contracts = ["crowdfunding::campaign::Campaign"]
diff --git a/listings/applications/coin_flip/Scarb.toml b/listings/applications/coin_flip/Scarb.toml
@@ -1,18 +1,16 @@
 [package]
 name = "coin_flip"
 version.workspace = true
-edition = "2024_07"
-
-[lib]
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true
 openzeppelin.workspace = true
 pragma_lib.workspace = true
-snforge_std.workspace = true
 
 [dev-dependencies]
 assert_macros.workspace = true
+snforge_std.workspace = true
 
 [scripts]
 test.workspace = true

diff --git a/listings/applications/components/Scarb.toml b/listings/applications/components/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "components"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [lib]
 

diff --git a/listings/applications/components_dependencies/Scarb.toml b/listings/applications/components_dependencies/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "components_dependencies"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/constant_product_amm/Scarb.toml b/listings/applications/constant_product_amm/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "constant_product_amm"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/crowdfunding/Scarb.toml b/listings/applications/crowdfunding/Scarb.toml
@@ -1,18 +1,18 @@
 [package]
 name = "crowdfunding"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [lib]
 
 [dependencies]
 starknet.workspace = true
 openzeppelin.workspace = true
 components.workspace = true
-snforge_std.workspace = true
 
 [dev-dependencies]
 assert_macros.workspace = true
+snforge_std.workspace = true
 
 [scripts]
 test.workspace = true

diff --git a/listings/applications/erc20/Scarb.toml b/listings/applications/erc20/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "erc20"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [lib]
 

diff --git a/listings/applications/merkle_tree/Scarb.toml b/listings/applications/merkle_tree/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "merkle_tree"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/nft_dutch_auction/Scarb.toml b/listings/applications/nft_dutch_auction/Scarb.toml
@@ -1,15 +1,15 @@
 [package]
 name = "nft_dutch_auction"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 erc20 = { path = "../erc20" }
 starknet.workspace = true
-snforge_std.workspace = true
 
 [dev-dependencies]
 assert_macros.workspace = true
+snforge_std.workspace = true
 
 [scripts]
 test.workspace = true

diff --git a/listings/applications/simple_storage_starknetjs/Scarb.toml b/listings/applications/simple_storage_starknetjs/Scarb.toml
@@ -1,9 +1,7 @@
 [package]
 name = "simple_storage"
 version.workspace = true
-edition = "2024_07"
-
-[lib]
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/simple_vault/Scarb.toml b/listings/applications/simple_vault/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "simple_vault"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/staking/Scarb.toml b/listings/applications/staking/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "staking"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/applications/timelock/Scarb.toml b/listings/applications/timelock/Scarb.toml
@@ -1,19 +1,18 @@
 [package]
 name = "timelock"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true
-snforge_std.workspace = true
 openzeppelin.workspace = true
 components.workspace = true
 
 [dev-dependencies]
 assert_macros.workspace = true
+snforge_std.workspace = true
 
 [scripts]
 test.workspace = true
 
 [[target.starknet-contract]]
-casm = true
diff --git a/listings/applications/upgradeable_contract/Scarb.toml b/listings/applications/upgradeable_contract/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "upgradeable_contract"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/bytearray/Scarb.toml b/listings/getting-started/bytearray/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "bytearray"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/cairo_cheatsheet/Scarb.toml b/listings/getting-started/cairo_cheatsheet/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "cairo_cheatsheet"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/calling_other_contracts/Scarb.toml b/listings/getting-started/calling_other_contracts/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "calling_other_contracts"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/constructor/Scarb.toml b/listings/getting-started/constructor/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "constructor"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/counter/Scarb.toml b/listings/getting-started/counter/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "counter"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/custom_type_serde/Scarb.toml b/listings/getting-started/custom_type_serde/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "custom_type_serde"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/errors/Scarb.toml b/listings/getting-started/errors/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "errors"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/events/Scarb.toml b/listings/getting-started/events/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "events"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/factory/Scarb.toml b/listings/getting-started/factory/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "factory"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/interfaces_traits/Scarb.toml b/listings/getting-started/interfaces_traits/Scarb.toml
@@ -1,7 +1,7 @@
 [package]
 name = "interfaces_traits"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true

diff --git a/listings/getting-started/mappings/Scarb.toml b/listings/getting-started/mappings/Scarb.toml
@@ -1,13 +1,13 @@
 [package]
 name = "mappings"
 version.workspace = true
-edition = "2024_07"
+edition.workspace = true
 
 [dependencies]
 starknet.workspace = true
 
 [dev-dependencies]
-cairo_test = "2.7.1"
+cairo_test.workspace = true
 
 [scripts]
 test.workspace = true