feat: migrate frontend framework from mdbook to vocs #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio4
requested changes
May 23, 2024
There was a problem hiding this comment.
Great! Is there a reason why you moved the listings directory to docs/snippets?
Default rootDir is ./docs, but it can be changed in vocs.config.ts. You should try to change it torootDir: '.' and see if we can keep listings and docs separated.
That way we can import the repository either as a scarb project (listings) or as a vocs project (docs)
julio4
approved these changes
Oct 3, 2024
julio4
pushed a commit
to julio4/StarknetByExample
that referenced
this pull request
Oct 25, 2024
* feat: migration to vocs * Update CONTRIBUTING.md * Update README.md * fix: pr review requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s): Closes #167
Description
Frontend migrated from mdbook to vocs