Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Abstraction - Spending Limits #236

Closed
wants to merge 4 commits into from

Conversation

egeaybars123
Copy link
Contributor

@egeaybars123 egeaybars123 commented Jul 22, 2024

Issue(s): Close #230

Description

Account Contract with Spending Limits for any ERC20 token.

Checklist

  • CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
  • Contract Tests: Added tests to cover the changes

@egeaybars123 egeaybars123 marked this pull request as ready for review July 22, 2024 10:16
@julio4
Copy link
Contributor

julio4 commented Aug 8, 2024

Hello @egeaybars123, do you want to continue working on this, or should I edit the last few changes by myself?

@egeaybars123
Copy link
Contributor Author

Hello @egeaybars123, do you want to continue working on this, or should I edit the last few changes by myself?

Hey @julio4, I can work on those changes if you could please provide me with the feedback.

@julio4
Copy link
Contributor

julio4 commented Aug 8, 2024

Hello @egeaybars123, do you want to continue working on this, or should I edit the last few changes by myself?

Hey @julio4, I can work on those changes if you could please provide me with the feedback.

My bad, I started a review and forgot to finish it. Let me finish it soon.

@julio4
Copy link
Contributor

julio4 commented Nov 20, 2024

@egeaybars123 The repository has been upgraded to a new site generator and the Markdown format to include code listings is slightly different. The CONTRIBUTING guidelines has been updated to reflect these changes.
Could you rebase this PR onto dev. If there's any issues or if you want me to do these changes let me know.

@egeaybars123
Copy link
Contributor Author

Hey @julio4, I am currently working on different things. I'd be really glad if you could make those changes! Have a great week.

@julio4 julio4 changed the base branch from main to dev November 21, 2024 02:49
@julio4
Copy link
Contributor

julio4 commented Dec 12, 2024

I'll close this in favor of #277
Feel free to review it if needed

@julio4 julio4 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Account Abstraction - Spending Limits
2 participants