Feature: L1 <> L2 messaging with Token Bridge example #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ToL2 + implement consumeWithdrawal
0xNeshi
changed the title
0xNeshi
commented
Oct 23, 2024
| @@ -0,0 +1 @@ | |||
| src/Vm.sol linguist-generated | |||
There was a problem hiding this comment.
A couple of notes/questions:
- I added tests for the Solidity contracts to ensure correctness, and opted for Foundry for consistency (as we already use it for Starknet contract tests). If you think this adds to many other files (see next point), and don't think they're that necessary for this example, we can delete.
forge-stdlibrary is included in the source, as it makes it any extra setup unnecessary to run tests for the SolidityTokenBridgein the future. Let me know if you want this removed, and we can add a README note with instructions on how to set this up.- I didn't update ./scripts/cairo_programs_verifier.sh to run Solidity tests, but this can be done.
0xNeshi
commented
Oct 23, 2024
| import "starknet/IStarknetMessaging.sol"; | ||
|
|
||
| /** | ||
| * @title Contract to bridge tokens to and from Starknet. Has basic access control |
There was a problem hiding this comment.
Let me know if you want me to remove some of these comments, I aimed for a contract that respects best dev practices, but not sure if it adds to much clutter to the code on the website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s): Close ##186
Description
Adds a simple token bridge example that sends and receives tokens from L1 to L2 and vice versa.
Checklist
./scripts/cairo_programs_verifier.shsuccessfullyTokenBridge: https://sepolia.starkscan.co/contract/0x03b738bfae36b3cbc966954370f74fc3b816f928f8781318b7ef66faf3b381f2MintableTokenMock: https://sepolia.starkscan.co/contract/0x2d1267d27b3ecab2af7a40dd1f8c3e44d421d6a873c0167991c5c0ae487f435TokenBridge: https://sepolia.etherscan.io/address/0x7c7bc92832bd8f273c5ad62057d65c006b1a5ad2MintableTokenMock: https://sepolia.etherscan.io/address/0xCbeF7249faFc05Cbd57ebC7cc3A4EEBf871424A1