Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New block proposal #43

Merged
merged 3 commits into from
Jul 2, 2024
Merged

New block proposal #43

merged 3 commits into from
Jul 2, 2024

Conversation

mskrzypkows
Copy link
Collaborator

No description provided.

@mskrzypkows
Copy link
Collaborator Author

For now, it's sending the new block proposal, I'll add another PR with returning of transaction as a bytes sequence.

@mskrzypkows mskrzypkows force-pushed the new_block_proposal branch from a528647 to 5fe9891 Compare July 2, 2024 15:19
@@ -26,6 +54,49 @@ impl EthereumL1 {
})
}

pub async fn propose_new_block(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is not invoked yet
Are we going to invoke it in the preconfirmation loop?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the idea. but in this code we are still calling RPC and not calling Chainbound Bolt MevBoost. we want to change that

@@ -26,6 +54,49 @@ impl EthereumL1 {
})
}

pub async fn propose_new_block(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the idea. but in this code we are still calling RPC and not calling Chainbound Bolt MevBoost. we want to change that

lookahead_set_param,
);

let tx_hash = builder.send().await?.watch().await?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like discussed lets get the Tx bytes from here so we can send them to Bolt mev boost

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just wanted to merge it first as some base for the validator index and slot discovery.
I'm preparing changes, which we talked about.

Copy link
Collaborator

@smartprogrammer93 smartprogrammer93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge then

@smartprogrammer93 smartprogrammer93 merged commit 739fc68 into master Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants