-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New block proposal #43
Conversation
For now, it's sending the new block proposal, I'll add another PR with returning of transaction as a bytes sequence. |
a528647
to
5fe9891
Compare
@@ -26,6 +54,49 @@ impl EthereumL1 { | |||
}) | |||
} | |||
|
|||
pub async fn propose_new_block( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function is not invoked yet
Are we going to invoke it in the preconfirmation loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the idea. but in this code we are still calling RPC and not calling Chainbound Bolt MevBoost. we want to change that
@@ -26,6 +54,49 @@ impl EthereumL1 { | |||
}) | |||
} | |||
|
|||
pub async fn propose_new_block( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the idea. but in this code we are still calling RPC and not calling Chainbound Bolt MevBoost. we want to change that
lookahead_set_param, | ||
); | ||
|
||
let tx_hash = builder.send().await?.watch().await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like discussed lets get the Tx bytes from here so we can send them to Bolt mev boost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just wanted to merge it first as some base for the validator index and slot discovery.
I'm preparing changes, which we talked about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge then
No description provided.