Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[juno-node] Fetch Juno version from API. #148

Merged
merged 3 commits into from
Sep 26, 2024
Merged

[juno-node] Fetch Juno version from API. #148

merged 3 commits into from
Sep 26, 2024

Conversation

PhilexWong
Copy link

  1. the juno version is changed from actual number to latest, so I have to change the code to fetch juno version from API.
  2. remove unnecessary value in value files.

@PhilexWong PhilexWong changed the title Fix: Fetch Juno version from API. [juno-node] Fetch Juno version from API. Sep 25, 2024
Manjeet-Nethermind
Manjeet-Nethermind approved these changes Sep 26, 2024
View reviewed changes
Copy link

@Manjeet-Nethermind Manjeet-Nethermind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gehlotanish
gehlotanish approved these changes Sep 26, 2024
View reviewed changes
Copy link

@gehlotanish gehlotanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilexWong PhilexWong merged commit 4f04684 into main Sep 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gehlotanish gehlotanish gehlotanish approved these changes

@Manjeet-Nethermind Manjeet-Nethermind Manjeet-Nethermind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilexWong @gehlotanish @Manjeet-Nethermind