Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, there's a small change when I use it, and I think it might be a problem. Please review it and check if it's correct.
For fix #3: On some machines, if the
hz_actual_friendly
field is not present in the CPU info, it will cause the whole test script to fail. So, getting the CPU frequency usingpsutil
might be better.I tried to add a new startup parameter
--o
so that you can specify the result folder location. This is useful because if you run the test multiple times on the same machine, using this flag can help store multiple results in the same project.About the report folder, I see the script creates
results/reports
in theresults
directory but does not use it, and currently generatesreports
in the project's root folder. Considering the addition of the--o
flag, I think all reports should follow theresults
directory. So, modify the reports location to be withinresults
.The previous JSON format in the
--imageBulk
argument had a syntax error due to an extra comma and quote. This caused a JSONDecodeError during script execution. The JSON string is now correctly formatted, ensuring successful parsing.Since the response file is appended at the end, I think we should base the comment on "get the latest line" by reading the last line of the file. The first line of the file might have a "SYNCING" status.
I'm not sure if these changes are satisfactory for this project, as I made the process easier for my use. Please review which changes are good for the project, and I will remove the incorrect changes.
This PR code has already run and generated results there: https://github.com/lyfsn/gas-benchmarks/actions/runs/9411197574