Pin buf plugin version #2395
Open
Pin buf plugin version #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 74.71% 74.86% +0.15%
==========================================
Files 110 111 +1
Lines 12105 12171 +66
==========================================
+ Hits 9044 9112 +68
+ Misses 2364 2358 -6
- Partials 697 701 +4 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
requested changes
Jan 26, 2025
There was a problem hiding this comment.
Thank you for your contribution!
Please check out this PR, which will be merged and rebase on this branch.
buf.gen.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| version: v2 | |||
| clean: true | |||
| plugins: | |||
| - remote: buf.build/protocolbuffers/go | |||
| - remote: buf.build/protocolbuffers/go:v1.36.0 | |||
There was a problem hiding this comment.
Could we use the latest version?
Suggested change
| - remote: buf.build/protocolbuffers/go:v1.36.0 | |
| - remote: buf.build/protocolbuffers/go:v1.36.3 |
Exca-DK
force-pushed
the
Exca-DK/buf-pin-version
branch
2 times, most recently
from
c3a2180 to
2798000
Compare
Exca-DK
force-pushed
the
Exca-DK/buf-pin-version
branch
from
1a200ee to
ba9f122
Compare
AnkushinDaniil
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
make generate-bufcommand was using the latest version, which caused diffs in the generated files. To maintain consistency, the version was pinned to the one recently used to generate the p2p files.