Added custom type for Deployed contracts throughout the repo wherever necessary #2402
+23
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
==========================================
- Coverage 74.48% 74.47% -0.02%
==========================================
Files 113 113
Lines 13020 13020
==========================================
- Hits 9698 9696 -2
- Misses 2587 2588 +1
- Partials 735 736 +1 ☔ View full report in Codecov by Sentry. |
|
We were looking for something with a bit more depth. I am going to close this PR for the time being. We can re-open it later or create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396
This PR introduces the structure
type StorageDiff map[felt.Felt]map[felt.Felt]*felt.Feltfor refactoringStorageDiffinitially asmap[felt.Felt]map[felt.Felt]*felt.Felt.It integrates the new struct throughout the repo wherever needed.