Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes aimed at improving the codebase by optimizing loops and adding new linters. The most significant changes include replacing traditional
for
loops withrange
loops, adding new linters to the configuration, and optimizing array initialization.Loop Optimization:
blockchain/blockchain.go
: ModifiedremoveTxsAndReceipts
function to userange
in the loop.blockchain/blockchain_test.go
: Updated multiple test functions to userange
loops instead of traditional loops. [1] [2] [3] [4] [5] [6] [7]clients/feeder/feeder.go
: Changed the retry loop inget
function to userange
for better readability.cmd/juno/juno_test.go
: Updated environment variable handling loops to userange
. [1] [2]core/crypto/ecdsa_test.go
,core/crypto/pedersen_hash_test.go
,core/crypto/poseidon_hash_test.go
: Replaced loops in benchmark functions withrange
. [1] [2] [3] [4] [5] [6] [7] [8] [9]Linter Configuration:
.golangci.yaml
: Added new lintersprealloc
,makezero
, andintrange
to the configuration.Array Initialization:
cmd/juno/dbcmd.go
: Optimized array initialization indbSize
function.core/trie/proof_test.go
: Updated array initialization in multiple test functions for better performance. [1] [2] [3] [4] [5]core/trie/trie_test.go
: Improved array initialization in benchmark functions. [1] [2]