Build only for Linux x64 on CI #7763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexb5dh
reviewed
Nov 15, 2024
src/Nethermind/Nethermind.Taiko.Test/TxPoolContentListsTests.cs
Outdated
Show resolved
Hide resolved
emlautarom1
force-pushed
the
fix/ci-single-platform
branch
from
306267e
to
a58d7cb
Compare
emlautarom1
commented
Nov 15, 2024
| <PropertyGroup Condition="'$(CI)' == 'true'"> | ||
| <!-- Required due to an issue with transitive dependencies of Colorful.Console --> | ||
| <!-- See: https://github.com/tomakita/Colorful.Console/pull/94 --> | ||
| <NoWarn>NU1605</NoWarn> |
There was a problem hiding this comment.
Colorful.Console does not officially support .NET 8 which causes issues when specifying runtimes. I'm not sure if the issue just does not show up in "normal" builds but is still there, or is it only due to the usage of specific runtimes.
Microsoft's docs are quite poor in this case and the proposed workaround just does not work: https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1605#example-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7762
Changes
linux-x64on Github WorkflowsTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
Notes on testing
CI should be green without affecting other workflows.
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
When running
dotnet buildwe're currently generating native files for platforms that we don't care about liketvos-arm64among several others. All of these files take considerable space which can cause issues due to disk usage on CI.In an ideal world we could list exactly the platforms that we target but alas this does not work (see dotnet/sdk#42153 for an extremely similar case), which limits us to specifying at most one single platform.