Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build only for Linux x64 on CI #7763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Build only for Linux x64 on CI #7763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c593933
Specify runtime on CI
emlautarom1 Nov 15, 2024
a58d7cb
Run tests with CI runtime
emlautarom1 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-solutions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
restore-keys: |
${{ runner.os }}-nuget-${{ hashFiles('**/Directory.Packages.props') }}
- name: Build ${{ matrix.solution }}.sln
run: dotnet build src/Nethermind/${{ matrix.solution }}.sln -c ${{ matrix.config }}
run: dotnet build src/Nethermind/${{ matrix.solution }}.sln -c ${{ matrix.config }} -p:CI=true
4 changes: 2 additions & 2 deletions .github/workflows/nethermind-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
- name: ${{ matrix.project }}
id: test
run: |
dotnet test src/Nethermind/${{ matrix.project }} -c release \
dotnet test src/Nethermind/${{ matrix.project }} -c release -p:CI=true \
${{ env.COLLECT_COVERAGE == 'true' && '--collect:"XPlat Code Coverage"' || '' }}
- name: Save test outcome
if: success() || failure()
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
- name: ${{ matrix.project }}
id: test
run: |
dotnet test src/Nethermind/${{ matrix.project }} -c release \
dotnet test src/Nethermind/${{ matrix.project }} -c release -p:CI=true \
${{ env.COLLECT_COVERAGE == 'true' && '--collect:"XPlat Code Coverage" -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Exclude=[Nethermind.Core.Test]*,[Nethermind.Blockchain.Test]*,[Ethereum.Test.Base]*' || '' }}
- name: Save test outcome
if: success() || failure()
Expand Down
7 changes: 7 additions & 0 deletions src/Nethermind/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<Project>

<PropertyGroup Condition="'$(CI)' == 'true'">
<!-- Required due to an issue with transitive dependencies of Colorful.Console -->
<!-- See: https://github.com/tomakita/Colorful.Console/pull/94 -->
<NoWarn>NU1605</NoWarn>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colorful.Console does not officially support .NET 8 which causes issues when specifying runtimes. I'm not sure if the issue just does not show up in "normal" builds but is still there, or is it only due to the usage of specific runtimes.

Microsoft's docs are quite poor in this case and the proposed workaround just does not work: https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1605#example-3

<RuntimeIdentifier>linux-x64</RuntimeIdentifier>
</PropertyGroup>

<PropertyGroup>
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
<ContinuousIntegrationBuild Condition="'$(CI)' == 'true'">true</ContinuousIntegrationBuild>
Expand Down
Loading