Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taiko #7326

Merged
merged 109 commits into from
Oct 24, 2024
Merged

Taiko #7326

merged 109 commits into from
Oct 24, 2024

Conversation

jmederosalvarado
Copy link
Member

@jmederosalvarado jmederosalvarado commented Aug 12, 2024 •
edited by flcl42
Loading

Taiko chain support

Changes

  • Separate custom timestamp comparison logic in ForkChoiceHandler so it does not break regular merge
  • Remove unused code
  • Improve Base64Converter
  • Fix licenses
  • Fix configs, rpc origin, and release spec, meta data
  • Check AlwaysPoS.FinalTotalDifficulty=0 reasoning
  • IsOnMainChainBehindHead is commented for taiko, fix for merge

Further prs:

  • Refactor ForkChoiceHandler
  • Recover addresses in the background threads to improve performance
  • Speed up sync by improving single peer/single fcu case
  • Make consts for all TransactionResult strings

Needs resync due to a database schema change

jmederosalvarado and others added 30 commits June 27, 2024 13:00
@jmederosalvarado
create taiko plugin
b1f94c4
@jmederosalvarado
Add IsAnchor field to tx
95b9b3b
@jmederosalvarado
State transition
af47ff0
@jmederosalvarado
Gigachain L1Origin store and decoding (#7227)
0653775
@jmederosalvarado
Gigachain engine api (#7230)
5b38012
@jmederosalvarado
Add executor that ignores invalid txs in block
1772ab0
@jmederosalvarado
Consider cases where tx execution fails with exception
f5fd0a9
@flcl42
Add RPC (#7225)
91ffe05
@jmederosalvarado
Skip blob transactions during execution
a957a00
@jmederosalvarado
Merge branch 'gigachain' of https://github.com/nethermindeth/nethermind…
3f62aed 
… into gigachain
@jmederosalvarado
Some setup
3d6c5fe
@jmederosalvarado
Engine payload building
290f5cf
@jmederosalvarado
Anchor tx validation
ef709e8
@flcl42
Improve RPC (#7231)
4aa3968
@jmederosalvarado
don't require block producer env factory
eb21b2a
@flcl42
Fix genesis, cfgs
1a0f156
@jmederosalvarado
engine fixes
bc4ac88
@jmederosalvarado
chainspec seal engine stuff
1beb144
@jmederosalvarado
Fix initialization
5ace420
@jmederosalvarado
general fixes
92cc9a1
@jmederosalvarado
fixes in blockv alidator
1686792
@jmederosalvarado
Recover sender address in block validator
a22c9d9
@jmederosalvarado
fix config
75e2fb3
@flcl42
Fix configs
a494261
@jmederosalvarado
tx processing changes
aee598d
@jmederosalvarado
override chainspec fee collector
db5df5a
@flcl42
Create anchor acc
cb9e0d9
@flcl42
Imrpove RPC
a03156e
@flcl42
Fix encoding
82b2998
@flcl42
Add RLP decoder
d294ed2
@flcl42 flcl42 requested a review from rubo October 15, 2024 09:01
emlautarom1
emlautarom1 reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some small details and questions. Before merging I suggest to extend the test suite.

src/Nethermind/Nethermind.Merge.Plugin/Handlers/ForkchoiceUpdatedHandler.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/IL1OriginStore.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoPlugin.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoPlugin.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoSimplePayloadPreparationService.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoSimplePayloadPreparationService.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoTxProcessor.cs Outdated Show resolved Hide resolved
LukaszRozmej
LukaszRozmej approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller potential improvements

src/Nethermind/Nethermind.Consensus/Producers/BlockToProduce.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoPayloadPreparationService.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoPayloadPreparationService.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoBlockValidator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/TaikoBlockValidator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/Rpc/TaikoEngineRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Taiko/BlockInvalidTxExecutor.cs Outdated Show resolved Hide resolved
emlautarom1
emlautarom1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flcl42 flcl42 merged commit d3d0ec0 into master Oct 24, 2024
75 checks passed
@flcl42 flcl42 deleted the taiko branch October 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcl42 flcl42 flcl42 left review comments

@rubo rubo rubo approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@emlautarom1 emlautarom1 emlautarom1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmederosalvarado @rubo @flcl42 @LukaszRozmej @emlautarom1 @benaadams