-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tracer output uniform for error dumps, debug_traceblock and trace_block rpc endpoints. #7479
Open
obasekiosa
wants to merge
8
commits into
master
Choose a base branch
from
refactor/7408-update-trace-structure-to-match-geth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make tracer output uniform for error dumps, debug_traceblock and trace_block rpc endpoints. #7479
obasekiosa
wants to merge
8
commits into
master
from
refactor/7408-update-trace-structure-to-match-geth
+117
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s temp and would be force removed on next push.
obasekiosa
force-pushed
the
refactor/7408-update-trace-structure-to-match-geth
branch
from
September 23, 2024 11:49
d198704
to
6cabae9
Compare
obasekiosa
changed the title
Find issue with tracer logs/trace rpc
Make tracer output uniform for error dumps, debug_traceblock and trace_block rpc endpoints.
Sep 23, 2024
obasekiosa
commented
Oct 14, 2024
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeBlockFileTracer.cs
Outdated
Show resolved
Hide resolved
obasekiosa
commented
Oct 14, 2024
src/Nethermind/Nethermind.Serialization.Json/EthereumJsonSerializer.cs
Outdated
Show resolved
Hide resolved
obasekiosa
requested review from
MarekM25,
LukaszRozmej and
damian-orzechowski
October 14, 2024 12:59
obasekiosa
commented
Oct 14, 2024
src/Nethermind/Nethermind.Evm/Tracing/GethStyle/GethLikeTxTrace.cs
Outdated
Show resolved
Hide resolved
obasekiosa
commented
Oct 14, 2024
obasekiosa
commented
Oct 14, 2024
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7408
Changes
Types of changes
What types of changes does your code introduce?
Testing
Test will need to be updated
Requires testing
If yes, did you write tests?
Notes on testing
Tests simply need to update the expected values.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Todo: should docs update first or after this?
Requires explanation in Release Notes
Remarks
This PR makes it easy to compare traces within nethermind client and also across nethermind and geth clients for the debug_traceblock api.
Maybe extend to other debug_* endpoints?