Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracer output uniform for error dumps, debug_traceblock and trace_block rpc endpoints. #7479

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

obasekiosa
Copy link
Contributor

Resolves #7408

Changes

  • Updates the Converter used for tracing on error trace dumps, debug_traceblock, trace_block endpoints Only

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Test will need to be updated

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Tests simply need to update the expected values.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.
Todo: should docs update first or after this?

Requires explanation in Release Notes

  • Yes
  • No

Remarks

This PR makes it easy to compare traces within nethermind client and also across nethermind and geth clients for the debug_traceblock api.
Maybe extend to other debug_* endpoints?

…s temp and would be force removed on next push.
@obasekiosa obasekiosa force-pushed the refactor/7408-update-trace-structure-to-match-geth branch from d198704 to 6cabae9 Compare September 23, 2024 11:49
@obasekiosa obasekiosa changed the title Find issue with tracer logs/trace rpc Make tracer output uniform for error dumps, debug_traceblock and trace_block rpc endpoints. Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make nethermind trace format/structure uniform across modules and with geth
1 participant